Fix SonarCloud reliability findings in the Studio dashboard

- Declare the dashboard query and studio functions methods public.
- Move the audit's ?action= handling out of the constructor into
  processRequest(), called explicitly by the Server block.
- Give the Updates block's hidden checkbox an id and a label reference.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

studio/classes/BxDolStudioDashboardQuery.php

@@ -18,7 +18,7 @@ class BxDolStudioDashboardQuery extends BxDolStudioPageQuery
      * A module's storage use split by where its files live: its objects on the Local engine and those on any remote engine.
      * @return array ['local' => ['size' => bytes, 'objects' => count], 'remote' => ['size' => bytes, 'objects' => count]]
      */
-    function getModuleStorageSizes($sModule)
+    public function getModuleStorageSizes($sModule)
     {
         $aResult = array('local' => array('size' => 0, 'objects' => 0), 'remote' => array('size' => 0, 'objects' => 0));
 
@@ -32,7 +32,7 @@ class BxDolStudioDashboardQuery extends BxDolStudioPageQuery
     /**
      * The storage objects under a name prefix, each with its engine and counters (the dashboard splits the system module's by hand).
      */
-    function getStorageObjects($sPrefix)
+    public function getStorageObjects($sPrefix)
     {
         return $this->getAll("SELECT `object`, `engine`, `current_size`, `current_number` FROM `sys_objects_storage` WHERE `object` LIKE " . $this->escape($sPrefix . '%') . " ORDER BY `object`");
     }
@@ -40,7 +40,7 @@ class BxDolStudioDashboardQuery extends BxDolStudioPageQuery
     /**
      * Users block (BxBaseStudioDashboard::serviceGetBlockUsers): every account.
      */
-    function getAccountsCount()
+    public function getAccountsCount()
     {
         return (int)$this->getOne("SELECT COUNT(*) FROM `sys_accounts`");
     }
@@ -48,7 +48,7 @@ class BxDolStudioDashboardQuery extends BxDolStudioPageQuery
     /**
      * Accounts seen since a moment: their last activity or login is at or after it.
      */
-    function getAccountsActiveCount($iSince)
+    public function getAccountsActiveCount($iSince)
     {
         return (int)$this->getOne("SELECT COUNT(*) FROM `sys_accounts` WHERE `active` >= :since_active OR `logged` >= :since_logged", ['since_active' => (int)$iSince, 'since_logged' => (int)$iSince]);
     }
@@ -56,7 +56,7 @@ class BxDolStudioDashboardQuery extends BxDolStudioPageQuery
     /**
      * Accounts online now: with a session touched within the online window, the way BxDolAccountQuery::isOnline counts one.
      */
-    function getAccountsOnlineCount()
+    public function getAccountsOnlineCount()
     {
         return (int)$this->getOne("SELECT COUNT(DISTINCT `ta`.`id`) FROM `sys_accounts` AS `ta` INNER JOIN `sys_sessions` AS `ts` ON `ta`.`id` = `ts`.`user_id` WHERE `ts`.`date` > (UNIX_TIMESTAMP() - 60 * :minutes)", ['minutes' => (int)getParam('sys_account_online_time')]);
     }
@@ -64,7 +64,7 @@ class BxDolStudioDashboardQuery extends BxDolStudioPageQuery
     /**
      * Profiles of a type whose account is online now, the way getAccountsOnlineCount counts an account.
      */
-    function getProfilesOnlineCount($sType)
+    public function getProfilesOnlineCount($sType)
     {
         return (int)$this->getOne("SELECT COUNT(DISTINCT `tp`.`id`) FROM `sys_profiles` AS `tp` INNER JOIN `sys_sessions` AS `ts` ON `tp`.`account_id` = `ts`.`user_id` WHERE `tp`.`type` = :type AND `ts`.`date` > (UNIX_TIMESTAMP() - 60 * :minutes)", ['type' => $sType, 'minutes' => (int)getParam('sys_account_online_time')]);
     }
@@ -89,7 +89,7 @@ class BxDolStudioDashboardQuery extends BxDolStudioPageQuery
      * profile, or an unconfirmed, pending or suspended one.
      * @return array of ['ID', 'Name' (a language key), 'Icon']
      */
-    function getLevels()
+    public function getLevels()
     {
         bx_import('BxDolAcl');
         $aPseudo = [MEMBERSHIP_ID_NON_MEMBER, MEMBERSHIP_ID_ACCOUNT, MEMBERSHIP_ID_UNCONFIRMED, MEMBERSHIP_ID_PENDING, MEMBERSHIP_ID_SUSPENDED];
@@ -100,7 +100,7 @@ class BxDolStudioDashboardQuery extends BxDolStudioPageQuery
      * Current members per level.
      * @return array level id => count
      */
-    function getLevelsMembersCount()
+    public function getLevelsMembersCount()
     {
         return $this->getPairs("SELECT `level`, COUNT(*) AS `count` FROM (" . $this->getLevelMembersSql() . ") AS `t` GROUP BY `level`", 'level', 'count');
     }
@@ -109,7 +109,7 @@ class BxDolStudioDashboardQuery extends BxDolStudioPageQuery
      * A level's current members by when they joined it, counted per calendar bucket like getAccountsAddedBy.
      * @return array bucket => count
      */
-    function getLevelMembersSinceBy($iLevel, $sFormat, $iSince)
+    public function getLevelMembersSinceBy($iLevel, $sFormat, $iSince)
     {
         return $this->getPairs("SELECT FROM_UNIXTIME(`since`, :format) AS `bucket`, COUNT(*) AS `count` FROM (" . $this->getLevelMembersSql() . ") AS `t` WHERE `level` = :level AND `since` >= :since GROUP BY `bucket` ORDER BY `bucket`", 'bucket', 'count', ['format' => $sFormat, 'level' => (int)$iLevel, 'since' => (int)$iSince]);
     }
@@ -117,7 +117,7 @@ class BxDolStudioDashboardQuery extends BxDolStudioPageQuery
     /**
      * A level's current members whose account is online now, the way getAccountsOnlineCount counts an account.
      */
-    function getLevelOnlineCount($iLevel)
+    public function getLevelOnlineCount($iLevel)
     {
         return (int)$this->getOne("SELECT COUNT(DISTINCT `t`.`id`) FROM (" . $this->getLevelMembersSql() . ") AS `t` INNER JOIN `sys_sessions` AS `ts` ON `ts`.`user_id` = `t`.`account_id` WHERE `t`.`level` = :level AND `ts`.`date` > (UNIX_TIMESTAMP() - 60 * :minutes)", ['level' => (int)$iLevel, 'minutes' => (int)getParam('sys_account_online_time')]);
     }
@@ -125,7 +125,7 @@ class BxDolStudioDashboardQuery extends BxDolStudioPageQuery
     /**
      * When the first account was added; 0 without accounts.
      */
-    function getAccountsFirstAdded()
+    public function getAccountsFirstAdded()
     {
         return (int)$this->getOne("SELECT MIN(`added`) FROM `sys_accounts` WHERE `added` > 0");
     }
@@ -134,7 +134,7 @@ class BxDolStudioDashboardQuery extends BxDolStudioPageQuery
      * Accounts added since a moment, counted per calendar bucket named by a MySQL date format ('%Y-%m-%d' days, '%Y-%m' months, '%Y' years).
      * @return array bucket => count
      */
-    function getAccountsAddedBy($sFormat, $iSince)
+    public function getAccountsAddedBy($sFormat, $iSince)
     {
         return $this->getPairs("SELECT FROM_UNIXTIME(`added`, :format) AS `bucket`, COUNT(*) AS `count` FROM `sys_accounts` WHERE `added` >= :since GROUP BY `bucket` ORDER BY `bucket`", 'bucket', 'count', ['format' => $sFormat, 'since' => (int)$iSince]);
     }
@@ -143,7 +143,7 @@ class BxDolStudioDashboardQuery extends BxDolStudioPageQuery
      * Accounts last seen (their latest activity or login) since a moment, counted per calendar bucket like getAccountsAddedBy.
      * @return array bucket => count
      */
-    function getAccountsSeenBy($sFormat, $iSince)
+    public function getAccountsSeenBy($sFormat, $iSince)
     {
         return $this->getPairs("SELECT FROM_UNIXTIME(GREATEST(`active`, `logged`), :format) AS `bucket`, COUNT(*) AS `count` FROM `sys_accounts` WHERE GREATEST(`active`, `logged`) >= :since GROUP BY `bucket` ORDER BY `bucket`", 'bucket', 'count', ['format' => $sFormat, 'since' => (int)$iSince]);
     }
@@ -152,7 +152,7 @@ class BxDolStudioDashboardQuery extends BxDolStudioPageQuery
      * Rows of a module's content table (a profile type's profiles) added since a moment, counted per calendar bucket like getAccountsAddedBy.
      * @return array bucket => count
      */
-    function getEntriesAddedBy($sTable, $sField, $sFormat, $iSince)
+    public function getEntriesAddedBy($sTable, $sField, $sFormat, $iSince)
     {
         $sTable = preg_replace('/[^a-zA-Z0-9_]/', '', $sTable);
         $sField = preg_replace('/[^a-zA-Z0-9_]/', '', $sField);
@@ -163,7 +163,7 @@ class BxDolStudioDashboardQuery extends BxDolStudioPageQuery
      * Profiles per type (the module that owns them), the system's own left out, with how many of them are active.
      * @return array of ['type', 'total', 'active']
      */
-    function getProfilesByType()
+    public function getProfilesByType()
     {
         return $this->getAll("SELECT `type`, COUNT(*) AS `total`, SUM(`status` = 'active') AS `active` FROM `sys_profiles` WHERE `type` <> 'system' GROUP BY `type` ORDER BY `total` DESC, `type` ASC");
     }
@@ -171,7 +171,7 @@ class BxDolStudioDashboardQuery extends BxDolStudioPageQuery
     /**
      * Whether remote storage is in use: some storage object lives on a remote engine, or new objects would (the default engine option).
      */
-    function isRemoteStorageUsed()
+    public function isRemoteStorageUsed()
     {
         if(getParam('sys_storage_default') != 'Local')
             return true;

studio/classes/BxDolStudioToolsAudit.php

@@ -90,7 +90,14 @@ class BxDolStudioToolsAudit extends BxDol
         $this->aRequiredApacheModules = array (
             'rewrite_module' => 'mod_rewrite',
         );
+    }
 
+    /**
+     * The links in the report (send a test email, phpinfo) come back to the page that shows it with ?action=...: answer
+     * them here and stop, so the page rendering them calls this before it renders anything.
+     */
+    public function processRequest()
+    {
         if (isset($_GET['action'])) {
             $sOutput = null;
             switch ($_GET['action']) {

studio/template/dbd_versions.html

@@ -20,7 +20,7 @@
                         <span aria-hidden="true" class="inline-block h-5 w-5 rounded-full shadow transform ring-0 transition ease-in-out duration-200 pointer-events-none"></span>
                     </button>
                     <!-- the site's switch script flips this checkbox and the on/off classes on click; the change saves the option -->
-                    <input type="checkbox" name="__name__" style="display:none" __checked_attr__ onchange="__js_object__.toggleOption('__name__', this)">
+                    <input type="checkbox" id="bx-dbd-vt-input-__name__" name="__name__" aria-labelledby="bx-dbd-vt-__name__" style="display:none" __checked_attr__ onchange="__js_object__.toggleOption('__name__', this)">
                 </div>
             </div>
         </bx_repeat:toggles>

studio/template/scripts/BxBaseStudioDashboard.php

@@ -543,8 +543,8 @@ class BxBaseStudioDashboard extends BxDolStudioDashboard
 
         $oTemplate = BxDolStudioTemplate::getInstance();
 
-        // Constructing the audit also answers its own requests (?action=audit_send_test_email / phpinfo) from the links in the report.
-        new BxDolStudioToolsAudit();
+        // the links in the audit report (?action=audit_send_test_email / phpinfo) come back to this page: answered before anything is rendered
+        (new BxDolStudioToolsAudit())->processRequest();
 
         $aTmplVarsGauges = $aTmplVarsItems = [];
         if($bDynamic) {

studio/template/scripts/BxBaseStudioFunctions.php

@@ -13,7 +13,7 @@ class BxBaseStudioFunctions extends BxBaseFunctions implements iBxDolSingleton
     /**
      * Studio draws a block's title icon as an inline Lucide SVG (like its menus), whatever the site's default iconset is.
      */
-    function designBoxContent ($sTitle, $sContent, $iTemplateNum = BX_DB_DEF, $mixedMenu = false, $mixedButtons = [])
+    public function designBoxContent ($sTitle, $sContent, $iTemplateNum = BX_DB_DEF, $mixedMenu = false, $mixedButtons = [])
     {
         if(is_array($sTitle) && !empty($sTitle[2]) && preg_match('/^[a-z0-9-]+$/', $sTitle[2]) && ($oIconset = BxDolIconset::getObjectInstance('sys_lucide')) && ($sSvg = $oIconset->getIconHtml($sTitle[2])) !== false)
             $sTitle[2] = $sSvg;
@@ -24,7 +24,7 @@ class BxBaseStudioFunctions extends BxBaseFunctions implements iBxDolSingleton
     /**
      * A Studio block may hand the caption ready-made markup (a segmented switcher, say) instead of a menu object.
      */
-    function designBoxMenu ($mixedMenu, $mixedButtons = [])
+    public function designBoxMenu ($mixedMenu, $mixedButtons = [])
     {
         if(is_string($mixedMenu) && strncmp(ltrim($mixedMenu), '<', 1) === 0)
             return $mixedMenu;