Ticket #5273 - Get rid of duplicates in code.

modules/base/text/classes/BxBaseModTextFormEntry.php

@@ -24,70 +24,70 @@ class BxBaseModTextFormEntry extends BxBaseModGeneralFormEntry
 
         $CNF = &$this->_oModule->_oConfig->CNF;
 
-        if(isset($CNF['FIELD_COVER']) && isset($this->aInputs[$CNF['FIELD_COVER']])) {
+        if(($sKf = 'FIELD_COVER') && ($sKs = 'OBJECT_STORAGE') && isset($CNF[$sKf], $CNF[$sKs]) && isset($this->aInputs[$CNF[$sKf]])) {
             if($this->_oModule->checkAllowedSetThumb() === CHECK_ACTION_RESULT_ALLOWED) {
-                $this->aInputs[$CNF['FIELD_COVER']]['storage_object'] = $CNF['OBJECT_STORAGE'];
-                $this->aInputs[$CNF['FIELD_COVER']]['uploaders'] = !empty($this->aInputs[$CNF['FIELD_COVER']]['value']) ? unserialize($this->aInputs[$CNF['FIELD_COVER']]['value']) : $CNF['OBJECT_UPLOADERS'];
-                $this->aInputs[$CNF['FIELD_COVER']]['upload_buttons_titles'] = array(
+                $this->aInputs[$CNF[$sKf]]['storage_object'] = $CNF[$sKs];
+                $this->aInputs[$CNF[$sKf]]['uploaders'] = !empty($this->aInputs[$CNF[$sKf]]['value']) ? unserialize($this->aInputs[$CNF[$sKf]]['value']) : $CNF['OBJECT_UPLOADERS'];
+                $this->aInputs[$CNF[$sKf]]['upload_buttons_titles'] = array(
                     'Simple' => _t($CNF['T']['form_field_covers_uploader_simple']), 
                     'HTML5' => _t($CNF['T']['form_field_covers_uploader_html5'])
                 );
-                $this->aInputs[$CNF['FIELD_COVER']]['images_transcoder'] = $CNF['OBJECT_IMAGES_TRANSCODER_PREVIEW'];
-                $this->aInputs[$CNF['FIELD_COVER']]['storage_private'] = 0;
-                $this->aInputs[$CNF['FIELD_COVER']]['multiple'] = false;
-                $this->aInputs[$CNF['FIELD_COVER']]['content_id'] = 0;
-                $this->aInputs[$CNF['FIELD_COVER']]['ghost_template'] = '';
+                $this->aInputs[$CNF[$sKf]]['images_transcoder'] = $CNF['OBJECT_IMAGES_TRANSCODER_PREVIEW'];
+                $this->aInputs[$CNF[$sKf]]['storage_private'] = 0;
+                $this->aInputs[$CNF[$sKf]]['multiple'] = false;
+                $this->aInputs[$CNF[$sKf]]['content_id'] = 0;
+                $this->aInputs[$CNF[$sKf]]['ghost_template'] = '';
             }
             else
-                unset($this->aInputs[$CNF['FIELD_COVER']]);
+                unset($this->aInputs[$CNF[$sKf]]);
         }
 
-        if(isset($CNF['FIELD_PHOTO']) && isset($this->aInputs[$CNF['FIELD_PHOTO']])) {
-            $this->aInputs[$CNF['FIELD_PHOTO']]['storage_object'] = $CNF['OBJECT_STORAGE_PHOTOS'];
-            $this->aInputs[$CNF['FIELD_PHOTO']]['uploaders'] = !empty($this->aInputs[$CNF['FIELD_PHOTO']]['value']) ? unserialize($this->aInputs[$CNF['FIELD_PHOTO']]['value']) : $CNF['OBJECT_UPLOADERS'];
-            $this->aInputs[$CNF['FIELD_PHOTO']]['images_transcoder'] = $CNF['OBJECT_IMAGES_TRANSCODER_PREVIEW_PHOTOS'];
-            $this->aInputs[$CNF['FIELD_PHOTO']]['storage_private'] = 0;
-            $this->aInputs[$CNF['FIELD_PHOTO']]['multiple'] = true;
-            $this->aInputs[$CNF['FIELD_PHOTO']]['content_id'] = 0;
-            $this->aInputs[$CNF['FIELD_PHOTO']]['ghost_template'] = '';
-            $this->aInputs[$CNF['FIELD_PHOTO']]['tr_attrs'] = array('class'=> 'bx-base-text-attachment-item');
+        if(($sKf = 'FIELD_PHOTO') && ($sKs = 'OBJECT_STORAGE_PHOTOS') && isset($CNF[$sKf], $CNF[$sKs]) && isset($this->aInputs[$CNF[$sKf]])) {
+            $this->aInputs[$CNF[$sKf]]['storage_object'] = $CNF[$sKs];
+            $this->aInputs[$CNF[$sKf]]['uploaders'] = !empty($this->aInputs[$CNF[$sKf]]['value']) ? unserialize($this->aInputs[$CNF[$sKf]]['value']) : $CNF['OBJECT_UPLOADERS'];
+            $this->aInputs[$CNF[$sKf]]['images_transcoder'] = $CNF['OBJECT_IMAGES_TRANSCODER_PREVIEW_PHOTOS'];
+            $this->aInputs[$CNF[$sKf]]['storage_private'] = 0;
+            $this->aInputs[$CNF[$sKf]]['multiple'] = true;
+            $this->aInputs[$CNF[$sKf]]['content_id'] = 0;
+            $this->aInputs[$CNF[$sKf]]['ghost_template'] = '';
+            $this->aInputs[$CNF[$sKf]]['tr_attrs'] = array('class'=> 'bx-base-text-attachment-item');
         }
 
-        if(isset($this->aInputs[$CNF['FIELD_VIDEO']])) {
-            $this->aInputs[$CNF['FIELD_VIDEO']]['storage_object'] = $CNF['OBJECT_STORAGE_VIDEOS'];
-            $this->aInputs[$CNF['FIELD_VIDEO']]['uploaders'] = !empty($this->aInputs[$CNF['FIELD_VIDEO']]['value']) ? unserialize($this->aInputs[$CNF['FIELD_VIDEO']]['value']) : $CNF['OBJECT_UPLOADERS'];
-            $this->aInputs[$CNF['FIELD_VIDEO']]['images_transcoder'] = $CNF['OBJECT_VIDEOS_TRANSCODERS']['poster_preview'];
-            $this->aInputs[$CNF['FIELD_VIDEO']]['storage_private'] = 0;
-            $this->aInputs[$CNF['FIELD_VIDEO']]['multiple'] = true;
-            $this->aInputs[$CNF['FIELD_VIDEO']]['content_id'] = 0;
-            $this->aInputs[$CNF['FIELD_VIDEO']]['ghost_template'] = '';
-            $this->aInputs[$CNF['FIELD_VIDEO']]['tr_attrs'] = array('class'=> 'bx-base-text-attachment-item');
-        }
-        
-        if(isset($this->aInputs[$CNF['FIELD_SOUND']])) {
-            $this->aInputs[$CNF['FIELD_SOUND']]['storage_object'] = $CNF['OBJECT_STORAGE_SOUNDS'];
-            $this->aInputs[$CNF['FIELD_SOUND']]['uploaders'] = !empty($this->aInputs[$CNF['FIELD_SOUND']]['value']) ? unserialize($this->aInputs[$CNF['FIELD_SOUND']]['value']) : $CNF['OBJECT_UPLOADERS'];
-            $this->aInputs[$CNF['FIELD_SOUND']]['images_transcoder'] = $CNF['OBJECT_IMAGES_TRANSCODER_PREVIEW_FILES'];
-            $this->aInputs[$CNF['FIELD_SOUND']]['storage_private'] = 0;
-            $this->aInputs[$CNF['FIELD_SOUND']]['multiple'] = true;
-            $this->aInputs[$CNF['FIELD_SOUND']]['content_id'] = 0;
-            $this->aInputs[$CNF['FIELD_SOUND']]['ghost_template'] = '';
-            $this->aInputs[$CNF['FIELD_SOUND']]['tr_attrs'] = array('class'=> 'bx-base-text-attachment-item');
+        if(($sKf = 'FIELD_SOUND') && ($sKs = 'OBJECT_STORAGE_SOUNDS')  && isset($CNF[$sKf], $CNF[$sKs]) && isset($this->aInputs[$CNF[$sKf]])) {
+            $this->aInputs[$CNF[$sKf]]['storage_object'] = $CNF[$sKs];
+            $this->aInputs[$CNF[$sKf]]['uploaders'] = !empty($this->aInputs[$CNF[$sKf]]['value']) ? unserialize($this->aInputs[$CNF[$sKf]]['value']) : $CNF['OBJECT_UPLOADERS'];
+            $this->aInputs[$CNF[$sKf]]['images_transcoder'] = $CNF['OBJECT_IMAGES_TRANSCODER_PREVIEW_FILES'];
+            $this->aInputs[$CNF[$sKf]]['storage_private'] = 0;
+            $this->aInputs[$CNF[$sKf]]['multiple'] = true;
+            $this->aInputs[$CNF[$sKf]]['content_id'] = 0;
+            $this->aInputs[$CNF[$sKf]]['ghost_template'] = '';
+            $this->aInputs[$CNF[$sKf]]['tr_attrs'] = array('class'=> 'bx-base-text-attachment-item');
         }
 
-        if (isset($CNF['FIELD_FILE']) && isset($this->aInputs[$CNF['FIELD_FILE']])) {
-            $this->aInputs[$CNF['FIELD_FILE']]['storage_object'] = $CNF['OBJECT_STORAGE_FILES'];
-            $this->aInputs[$CNF['FIELD_FILE']]['uploaders'] = !empty($this->aInputs[$CNF['FIELD_FILE']]['value']) ? unserialize($this->aInputs[$CNF['FIELD_FILE']]['value']) : $CNF['OBJECT_UPLOADERS'];
-            $this->aInputs[$CNF['FIELD_FILE']]['images_transcoder'] = $CNF['OBJECT_IMAGES_TRANSCODER_PREVIEW_FILES'];
-            $this->aInputs[$CNF['FIELD_FILE']]['storage_private'] = 0;
-            $this->aInputs[$CNF['FIELD_FILE']]['multiple'] = true;
-            $this->aInputs[$CNF['FIELD_FILE']]['content_id'] = 0;
-            $this->aInputs[$CNF['FIELD_FILE']]['ghost_template'] = '';
-            $this->aInputs[$CNF['FIELD_FILE']]['tr_attrs'] = array('class'=> 'bx-base-text-attachment-item');
+        if(($sKf = 'FIELD_VIDEO') && ($sKs = 'OBJECT_STORAGE_VIDEOS') && isset($CNF[$sKf], $CNF[$sKs]) && isset($this->aInputs[$CNF[$sKf]])) {
+            $this->aInputs[$CNF[$sKf]]['storage_object'] = $CNF[$sKs];
+            $this->aInputs[$CNF[$sKf]]['uploaders'] = !empty($this->aInputs[$CNF[$sKf]]['value']) ? unserialize($this->aInputs[$CNF[$sKf]]['value']) : $CNF['OBJECT_UPLOADERS'];
+            $this->aInputs[$CNF[$sKf]]['images_transcoder'] = $CNF['OBJECT_VIDEOS_TRANSCODERS']['poster_preview'];
+            $this->aInputs[$CNF[$sKf]]['storage_private'] = 0;
+            $this->aInputs[$CNF[$sKf]]['multiple'] = true;
+            $this->aInputs[$CNF[$sKf]]['content_id'] = 0;
+            $this->aInputs[$CNF[$sKf]]['ghost_template'] = '';
+            $this->aInputs[$CNF[$sKf]]['tr_attrs'] = array('class'=> 'bx-base-text-attachment-item');
+        }
+        
+        if(($sKf = 'FIELD_FILE') && ($sKs = 'OBJECT_STORAGE_FILES') && isset($CNF[$sKf], $CNF[$sKs]) && isset($this->aInputs[$CNF[$sKf]])) {
+            $this->aInputs[$CNF[$sKf]]['storage_object'] = $CNF[$sKs];
+            $this->aInputs[$CNF[$sKf]]['uploaders'] = !empty($this->aInputs[$CNF[$sKf]]['value']) ? unserialize($this->aInputs[$CNF[$sKf]]['value']) : $CNF['OBJECT_UPLOADERS'];
+            $this->aInputs[$CNF[$sKf]]['images_transcoder'] = $CNF['OBJECT_IMAGES_TRANSCODER_PREVIEW_FILES'];
+            $this->aInputs[$CNF[$sKf]]['storage_private'] = 0;
+            $this->aInputs[$CNF[$sKf]]['multiple'] = true;
+            $this->aInputs[$CNF[$sKf]]['content_id'] = 0;
+            $this->aInputs[$CNF[$sKf]]['ghost_template'] = '';
+            $this->aInputs[$CNF[$sKf]]['tr_attrs'] = array('class'=> 'bx-base-text-attachment-item');
         }
 
-        if(isset($this->aInputs[$CNF['FIELD_POLL']])) {
-            $this->aInputs[$CNF['FIELD_POLL']]['tr_attrs'] = array('class'=> 'bx-base-text-attachment-item');
+        if(($sKf = 'FIELD_POLL') && isset($CNF[$sKf]) && isset($this->aInputs[$CNF[$sKf]])) {
+            $this->aInputs[$CNF[$sKf]]['tr_attrs'] = array('class'=> 'bx-base-text-attachment-item');
         }
     }