Ticket #3868 - Disabling covers disables submenu sitewide

inc/classes/BxDolCover.php

@@ -109,6 +109,14 @@ class BxDolCover extends BxDolFactory implements iBxDolSingleton
         return $o->getFileUrlById($mixedImage['id']);
     }
 
+    /**
+     * Determine whether cover is enabled globally or not.
+     */
+    public function isEnabled()
+    {
+        return getParam('sys_site_cover_disabled') != 'on';
+    }
+
     /**
      * Determine whether cover is already set for the page or not.  
      */

inc/classes/BxDolTemplate.php

@@ -1673,12 +1673,9 @@ class BxDolTemplate extends BxDolFactory implements iBxDolSingleton
                 break;
             case 'cover':
             	$oCover = BxDolCover::getInstance($this);
-            	if(!$oCover)
-                    break;
 
-            	$bCover = true;
-            	$oPage = BxDolPage::getObjectInstanceByURI();
-            	if($oPage !== false) {
+            	$bCover = $oCover->isEnabled();
+            	if($bCover && ($oPage = BxDolPage::getObjectInstanceByURI()) !== false) {
                     $bCover = $oPage->isPageCover();
                     if($bCover && !$oCover->isCover()) {
                         $aCover = $oPage->getPageCoverImage();

template/scripts/BxBaseCover.php

@@ -32,9 +32,6 @@ class BxBaseCover extends BxDolCover
      */
     public function display ()
     {
-        if (getParam('sys_site_cover_disabled') == 'on')
-            return '';
-
         $this->_addJsCss();
 
         $sResult = null;