tun_darwin.go 16 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670
  1. //go:build !ios && !e2e_testing
  2. package overlay
  3. import (
  4. "errors"
  5. "fmt"
  6. "log/slog"
  7. "net/netip"
  8. "os"
  9. "sync/atomic"
  10. "syscall"
  11. "unsafe"
  12. "github.com/gaissmai/bart"
  13. "github.com/slackhq/nebula/config"
  14. "github.com/slackhq/nebula/overlay/tio"
  15. "github.com/slackhq/nebula/routing"
  16. "github.com/slackhq/nebula/util"
  17. netroute "golang.org/x/net/route"
  18. "golang.org/x/sys/unix"
  19. )
  20. type tun struct {
  21. f *os.File
  22. Device string
  23. vpnNetworks []netip.Prefix
  24. DefaultMTU int
  25. Routes atomic.Pointer[[]Route]
  26. routeTree atomic.Pointer[bart.Table[routing.Gateways]]
  27. linkAddr *netroute.LinkAddr
  28. // hostOwned means the fd arrived from the OS, which has already configured addressing, mtu
  29. // and routes for it. NEPacketTunnelProvider on darwin does this.
  30. hostOwned bool
  31. l *slog.Logger
  32. }
  33. type ifReq struct {
  34. Name [unix.IFNAMSIZ]byte
  35. Flags uint16
  36. pad [8]byte
  37. }
  38. const (
  39. _SIOCAIFADDR_IN6 = 2155899162
  40. _UTUN_OPT_IFNAME = 2
  41. _IN6_IFF_NODAD = 0x0020
  42. _IN6_IFF_SECURED = 0x0400
  43. utunControlName = "com.apple.net.utun_control"
  44. )
  45. type ifreqMTU struct {
  46. Name [16]byte
  47. MTU int32
  48. pad [8]byte
  49. }
  50. type addrLifetime struct {
  51. Expire float64
  52. Preferred float64
  53. Vltime uint32
  54. Pltime uint32
  55. }
  56. type ifreqAlias4 struct {
  57. Name [unix.IFNAMSIZ]byte
  58. Addr unix.RawSockaddrInet4
  59. DstAddr unix.RawSockaddrInet4
  60. MaskAddr unix.RawSockaddrInet4
  61. }
  62. type ifreqAlias6 struct {
  63. Name [unix.IFNAMSIZ]byte
  64. Addr unix.RawSockaddrInet6
  65. DstAddr unix.RawSockaddrInet6
  66. PrefixMask unix.RawSockaddrInet6
  67. Flags uint32
  68. Lifetime addrLifetime
  69. }
  70. func newTun(c *config.C, l *slog.Logger, vpnNetworks []netip.Prefix, _ bool) (*tun, error) {
  71. name := c.GetString("tun.dev", "")
  72. ifIndex := -1
  73. if name != "" && name != "utun" {
  74. _, err := fmt.Sscanf(name, "utun%d", &ifIndex)
  75. if err != nil || ifIndex < 0 {
  76. // NOTE: we don't make this error so we don't break existing
  77. // configs that set a name before it was used.
  78. l.Warn("interface name must be utun[0-9]+ on Darwin, ignoring")
  79. ifIndex = -1
  80. }
  81. }
  82. fd, err := unix.Socket(unix.AF_SYSTEM, unix.SOCK_DGRAM, unix.AF_SYS_CONTROL)
  83. if err != nil {
  84. return nil, fmt.Errorf("system socket: %v", err)
  85. }
  86. var ctlInfo = &unix.CtlInfo{}
  87. copy(ctlInfo.Name[:], utunControlName)
  88. err = unix.IoctlCtlInfo(fd, ctlInfo)
  89. if err != nil {
  90. return nil, fmt.Errorf("CTLIOCGINFO: %v", err)
  91. }
  92. err = unix.Connect(fd, &unix.SockaddrCtl{
  93. ID: ctlInfo.Id,
  94. Unit: uint32(ifIndex) + 1,
  95. })
  96. if err != nil {
  97. return nil, fmt.Errorf("SYS_CONNECT: %v", err)
  98. }
  99. name, err = unix.GetsockoptString(fd, unix.AF_SYS_CONTROL, _UTUN_OPT_IFNAME)
  100. if err != nil {
  101. return nil, fmt.Errorf("failed to retrieve tun name: %w", err)
  102. }
  103. err = unix.SetNonblock(fd, true)
  104. if err != nil {
  105. return nil, fmt.Errorf("SetNonblock: %v", err)
  106. }
  107. t := &tun{
  108. f: os.NewFile(uintptr(fd), ""),
  109. Device: name,
  110. vpnNetworks: vpnNetworks,
  111. DefaultMTU: c.GetInt("tun.mtu", DefaultMTU),
  112. l: l,
  113. }
  114. err = t.reload(c, true)
  115. if err != nil {
  116. return nil, err
  117. }
  118. c.RegisterReloadCallback(func(c *config.C) {
  119. err := t.reload(c, false)
  120. if err != nil {
  121. util.LogWithContextIfNeeded("failed to reload tun device", err, t.l)
  122. }
  123. })
  124. return t, nil
  125. }
  126. func (t *tun) deviceBytes() (o [16]byte) {
  127. for i, c := range t.Device {
  128. o[i] = byte(c)
  129. }
  130. return
  131. }
  132. // newTunFromFd adopts a utun the host already created and configured, which is how a darwin
  133. // network extension is handed its device. Everything about moving packets is shared with newTun,
  134. // only the setup differs: the host owns addressing and routing here.
  135. func newTunFromFd(c *config.C, l *slog.Logger, deviceFd int, vpnNetworks []netip.Prefix) (*tun, error) {
  136. if err := unix.SetNonblock(deviceFd, true); err != nil {
  137. // We own the fd from the moment it is handed to us
  138. _ = unix.Close(deviceFd)
  139. return nil, fmt.Errorf("failed to set the tun fd to non-blocking mode: %w", err)
  140. }
  141. file := os.NewFile(uintptr(deviceFd), "/dev/tun")
  142. t := &tun{
  143. f: file,
  144. Device: utunNameFromFd(deviceFd),
  145. vpnNetworks: vpnNetworks,
  146. DefaultMTU: c.GetInt("tun.mtu", DefaultMTU),
  147. hostOwned: true,
  148. l: l,
  149. }
  150. if err := t.reload(c, true); err != nil {
  151. _ = file.Close()
  152. return nil, err
  153. }
  154. c.RegisterReloadCallback(func(c *config.C) {
  155. if err := t.reload(c, false); err != nil {
  156. util.LogWithContextIfNeeded("failed to reload tun device", err, t.l)
  157. }
  158. })
  159. return t, nil
  160. }
  161. // utunNameFromFd asks the socket what interface it is, for logs. A blank name is not worth
  162. // failing a tunnel over, so an error just leaves it empty.
  163. func utunNameFromFd(fd int) string {
  164. name, err := unix.GetsockoptString(fd, unix.AF_SYS_CONTROL, _UTUN_OPT_IFNAME)
  165. if err != nil {
  166. return ""
  167. }
  168. return name
  169. }
  170. func (t *tun) Close() error {
  171. if t.f != nil {
  172. return t.f.Close()
  173. }
  174. return nil
  175. }
  176. func (t *tun) Activate() error {
  177. // The host handed us a configured device. Its addresses, mtu and routes come from the network
  178. // settings it applied, and a sandboxed extension cannot change them anyway.
  179. if t.hostOwned {
  180. return nil
  181. }
  182. devName := t.deviceBytes()
  183. s, err := unix.Socket(
  184. unix.AF_INET,
  185. unix.SOCK_DGRAM,
  186. unix.IPPROTO_IP,
  187. )
  188. if err != nil {
  189. return err
  190. }
  191. defer unix.Close(s)
  192. fd := uintptr(s)
  193. // Set the MTU on the device
  194. ifm := ifreqMTU{Name: devName, MTU: int32(t.DefaultMTU)}
  195. if err = ioctl(fd, unix.SIOCSIFMTU, uintptr(unsafe.Pointer(&ifm))); err != nil {
  196. return fmt.Errorf("failed to set tun mtu: %v", err)
  197. }
  198. // Get the device flags
  199. ifrf := ifReq{Name: devName}
  200. if err = ioctl(fd, unix.SIOCGIFFLAGS, uintptr(unsafe.Pointer(&ifrf))); err != nil {
  201. return fmt.Errorf("failed to get tun flags: %s", err)
  202. }
  203. linkAddr, err := getLinkAddr(t.Device)
  204. if err != nil {
  205. return err
  206. }
  207. if linkAddr == nil {
  208. return fmt.Errorf("unable to discover link_addr for tun interface")
  209. }
  210. t.linkAddr = linkAddr
  211. for _, network := range t.vpnNetworks {
  212. if network.Addr().Is4() {
  213. err = t.activate4(network)
  214. if err != nil {
  215. return err
  216. }
  217. } else {
  218. err = t.activate6(network)
  219. if err != nil {
  220. return err
  221. }
  222. }
  223. }
  224. // Run the interface
  225. ifrf.Flags = ifrf.Flags | unix.IFF_UP | unix.IFF_RUNNING
  226. if err = ioctl(fd, unix.SIOCSIFFLAGS, uintptr(unsafe.Pointer(&ifrf))); err != nil {
  227. return fmt.Errorf("failed to run tun device: %s", err)
  228. }
  229. // Unsafe path routes
  230. return t.addRoutes(false)
  231. }
  232. func (t *tun) activate4(network netip.Prefix) error {
  233. s, err := unix.Socket(
  234. unix.AF_INET,
  235. unix.SOCK_DGRAM,
  236. unix.IPPROTO_IP,
  237. )
  238. if err != nil {
  239. return err
  240. }
  241. defer unix.Close(s)
  242. ifr := ifreqAlias4{
  243. Name: t.deviceBytes(),
  244. Addr: unix.RawSockaddrInet4{
  245. Len: unix.SizeofSockaddrInet4,
  246. Family: unix.AF_INET,
  247. Addr: network.Addr().As4(),
  248. },
  249. DstAddr: unix.RawSockaddrInet4{
  250. Len: unix.SizeofSockaddrInet4,
  251. Family: unix.AF_INET,
  252. Addr: network.Addr().As4(),
  253. },
  254. MaskAddr: unix.RawSockaddrInet4{
  255. Len: unix.SizeofSockaddrInet4,
  256. Family: unix.AF_INET,
  257. Addr: prefixToMask(network).As4(),
  258. },
  259. }
  260. if err := ioctl(uintptr(s), unix.SIOCAIFADDR, uintptr(unsafe.Pointer(&ifr))); err != nil {
  261. return fmt.Errorf("failed to set tun v4 address: %s", err)
  262. }
  263. err = addRoute(network, t.linkAddr)
  264. if err != nil {
  265. return err
  266. }
  267. return nil
  268. }
  269. func (t *tun) activate6(network netip.Prefix) error {
  270. s, err := unix.Socket(
  271. unix.AF_INET6,
  272. unix.SOCK_DGRAM,
  273. unix.IPPROTO_IP,
  274. )
  275. if err != nil {
  276. return err
  277. }
  278. defer unix.Close(s)
  279. ifr := ifreqAlias6{
  280. Name: t.deviceBytes(),
  281. Addr: unix.RawSockaddrInet6{
  282. Len: unix.SizeofSockaddrInet6,
  283. Family: unix.AF_INET6,
  284. Addr: network.Addr().As16(),
  285. },
  286. PrefixMask: unix.RawSockaddrInet6{
  287. Len: unix.SizeofSockaddrInet6,
  288. Family: unix.AF_INET6,
  289. Addr: prefixToMask(network).As16(),
  290. },
  291. Lifetime: addrLifetime{
  292. // never expires
  293. Vltime: 0xffffffff,
  294. Pltime: 0xffffffff,
  295. },
  296. Flags: _IN6_IFF_NODAD,
  297. }
  298. if err := ioctl(uintptr(s), _SIOCAIFADDR_IN6, uintptr(unsafe.Pointer(&ifr))); err != nil {
  299. return fmt.Errorf("failed to set tun address: %s", err)
  300. }
  301. return nil
  302. }
  303. func (t *tun) reload(c *config.C, initial bool) error {
  304. change, routes, err := getAllRoutesFromConfig(c, t.vpnNetworks, initial)
  305. if err != nil {
  306. return err
  307. }
  308. if !initial && !change {
  309. return nil
  310. }
  311. routeTree, err := makeRouteTree(t.l, routes, false)
  312. if err != nil {
  313. return err
  314. }
  315. // Teach nebula how to handle the routes before establishing them in the system table
  316. oldRoutes := t.Routes.Swap(&routes)
  317. t.routeTree.Store(routeTree)
  318. if !initial {
  319. // Remove first, if the system removes a wanted route hopefully it will be re-added next
  320. err := t.removeRoutes(findRemovedRoutes(routes, *oldRoutes))
  321. if err != nil {
  322. util.LogWithContextIfNeeded("Failed to remove routes", err, t.l)
  323. }
  324. // Ensure any routes we actually want are installed
  325. err = t.addRoutes(true)
  326. if err != nil {
  327. // Catch any stray logs
  328. util.LogWithContextIfNeeded("Failed to add routes", err, t.l)
  329. }
  330. }
  331. return nil
  332. }
  333. func (t *tun) RoutesFor(ip netip.Addr) routing.Gateways {
  334. r, ok := t.routeTree.Load().Lookup(ip)
  335. if ok {
  336. return r
  337. }
  338. return routing.Gateways{}
  339. }
  340. // Get the LinkAddr for the interface of the given name
  341. // Is there an easier way to fetch this when we create the interface?
  342. // Maybe SIOCGIFINDEX? but this doesn't appear to exist in the darwin headers.
  343. func getLinkAddr(name string) (*netroute.LinkAddr, error) {
  344. rib, err := netroute.FetchRIB(unix.AF_UNSPEC, unix.NET_RT_IFLIST, 0)
  345. if err != nil {
  346. return nil, err
  347. }
  348. msgs, err := netroute.ParseRIB(unix.NET_RT_IFLIST, rib)
  349. if err != nil {
  350. return nil, err
  351. }
  352. for _, m := range msgs {
  353. switch m := m.(type) {
  354. case *netroute.InterfaceMessage:
  355. if m.Name == name {
  356. sa, ok := m.Addrs[unix.RTAX_IFP].(*netroute.LinkAddr)
  357. if ok {
  358. return sa, nil
  359. }
  360. }
  361. }
  362. }
  363. return nil, nil
  364. }
  365. func (t *tun) addRoutes(logErrors bool) error {
  366. // The route tree is still ours, the system routing table is not
  367. if t.hostOwned {
  368. return nil
  369. }
  370. routes := *t.Routes.Load()
  371. for _, r := range routes {
  372. if len(r.Via) == 0 || !r.Install {
  373. // We don't allow route MTUs so only install routes with a via
  374. continue
  375. }
  376. err := addRoute(r.Cidr, t.linkAddr)
  377. if err != nil {
  378. if errors.Is(err, unix.EEXIST) {
  379. t.l.Warn("unable to add unsafe_route, identical route already exists", "route", r.Cidr)
  380. } else {
  381. retErr := util.NewContextualError("Failed to add route", map[string]any{"route": r}, err)
  382. if logErrors {
  383. retErr.Log(t.l)
  384. } else {
  385. return retErr
  386. }
  387. }
  388. } else {
  389. t.l.Info("Added route", "route", r)
  390. }
  391. }
  392. return nil
  393. }
  394. func (t *tun) removeRoutes(routes []Route) error {
  395. if t.hostOwned {
  396. return nil
  397. }
  398. for _, r := range routes {
  399. if !r.Install {
  400. continue
  401. }
  402. err := delRoute(r.Cidr, t.linkAddr)
  403. if err != nil {
  404. t.l.Error("Failed to remove route", "error", err, "route", r)
  405. } else {
  406. t.l.Info("Removed route", "route", r)
  407. }
  408. }
  409. return nil
  410. }
  411. func addRoute(prefix netip.Prefix, gateway netroute.Addr) error {
  412. sock, err := unix.Socket(unix.AF_ROUTE, unix.SOCK_RAW, unix.AF_UNSPEC)
  413. if err != nil {
  414. return fmt.Errorf("unable to create AF_ROUTE socket: %v", err)
  415. }
  416. defer unix.Close(sock)
  417. route := &netroute.RouteMessage{
  418. Version: unix.RTM_VERSION,
  419. Type: unix.RTM_ADD,
  420. Flags: unix.RTF_UP,
  421. Seq: 1,
  422. }
  423. if prefix.Addr().Is4() {
  424. route.Addrs = []netroute.Addr{
  425. unix.RTAX_DST: &netroute.Inet4Addr{IP: prefix.Masked().Addr().As4()},
  426. unix.RTAX_NETMASK: &netroute.Inet4Addr{IP: prefixToMask(prefix).As4()},
  427. unix.RTAX_GATEWAY: gateway,
  428. }
  429. } else {
  430. route.Addrs = []netroute.Addr{
  431. unix.RTAX_DST: &netroute.Inet6Addr{IP: prefix.Masked().Addr().As16()},
  432. unix.RTAX_NETMASK: &netroute.Inet6Addr{IP: prefixToMask(prefix).As16()},
  433. unix.RTAX_GATEWAY: gateway,
  434. }
  435. }
  436. data, err := route.Marshal()
  437. if err != nil {
  438. return fmt.Errorf("failed to create route.RouteMessage: %w", err)
  439. }
  440. _, err = unix.Write(sock, data[:])
  441. if err != nil {
  442. return fmt.Errorf("failed to write route.RouteMessage to socket: %w", err)
  443. }
  444. return nil
  445. }
  446. func delRoute(prefix netip.Prefix, gateway netroute.Addr) error {
  447. sock, err := unix.Socket(unix.AF_ROUTE, unix.SOCK_RAW, unix.AF_UNSPEC)
  448. if err != nil {
  449. return fmt.Errorf("unable to create AF_ROUTE socket: %v", err)
  450. }
  451. defer unix.Close(sock)
  452. route := netroute.RouteMessage{
  453. Version: unix.RTM_VERSION,
  454. Type: unix.RTM_DELETE,
  455. Seq: 1,
  456. }
  457. if prefix.Addr().Is4() {
  458. route.Addrs = []netroute.Addr{
  459. unix.RTAX_DST: &netroute.Inet4Addr{IP: prefix.Masked().Addr().As4()},
  460. unix.RTAX_NETMASK: &netroute.Inet4Addr{IP: prefixToMask(prefix).As4()},
  461. unix.RTAX_GATEWAY: gateway,
  462. }
  463. } else {
  464. route.Addrs = []netroute.Addr{
  465. unix.RTAX_DST: &netroute.Inet6Addr{IP: prefix.Masked().Addr().As16()},
  466. unix.RTAX_NETMASK: &netroute.Inet6Addr{IP: prefixToMask(prefix).As16()},
  467. unix.RTAX_GATEWAY: gateway,
  468. }
  469. }
  470. data, err := route.Marshal()
  471. if err != nil {
  472. return fmt.Errorf("failed to create route.RouteMessage: %w", err)
  473. }
  474. _, err = unix.Write(sock, data[:])
  475. if err != nil {
  476. return fmt.Errorf("failed to write route.RouteMessage to socket: %w", err)
  477. }
  478. return nil
  479. }
  480. // tunWritev and tunReadv are linkname'd to x/sys/unix's libc-routed writev/readv stubs so the
  481. // calls go through libSystem's pinned trampoline. A raw syscall.Syscall(SYS_WRITEV/SYS_READV, ...)
  482. // on darwin/arm64 emits an SVC #0x80 trap (see $GOROOT/src/syscall/asm_darwin_arm64.s), the path
  483. // Apple keeps warning they will eventually disallow. We pull the low-level stubs instead of calling
  484. // unix.Writev/unix.Readv because those take [][]byte and rebuild the []Iovec every call, which
  485. // heap-allocates the header; linkname'ing the stubs lets us hand them our own stack-allocated
  486. // iovecs. See golang/go#78049.
  487. //go:linkname tunWritev golang.org/x/sys/unix.writev
  488. //go:noescape
  489. func tunWritev(fd int, iovecs []unix.Iovec) (n int, err error)
  490. //go:linkname tunReadv golang.org/x/sys/unix.readv
  491. //go:noescape
  492. func tunReadv(fd int, iovecs []unix.Iovec) (n int, err error)
  493. // Read pulls one IP packet off the utun device, scattering the 4 byte protocol header away from
  494. // the packet so the payload lands directly in to.
  495. func (t *tun) Read(to []byte) (int, error) {
  496. var head [4]byte
  497. rc, err := t.f.SyscallConn()
  498. if err != nil {
  499. return 0, err
  500. }
  501. var n int
  502. var callErr error
  503. err = rc.Read(func(fd uintptr) bool {
  504. iovecs := []unix.Iovec{
  505. {Base: &head[0], Len: 4},
  506. {Base: &to[0], Len: uint64(len(to))},
  507. }
  508. n, callErr = tunReadv(int(fd), iovecs)
  509. if errno, ok := callErr.(syscall.Errno); ok && errno.Temporary() {
  510. return false
  511. }
  512. return true
  513. })
  514. if err != nil {
  515. return 0, err
  516. }
  517. if callErr != nil {
  518. return 0, callErr
  519. }
  520. if n < 4 {
  521. return 0, nil
  522. }
  523. return n - 4, nil
  524. }
  525. // Write pushes one IP packet onto the utun device. Safe for concurrent use:
  526. // the AF prefix and iovecs are per-call stack state, and the fd write itself
  527. // serializes on the runtime's fd mutex (see the Queue contract in tio.go).
  528. func (t *tun) Write(from []byte) (int, error) {
  529. if len(from) == 0 {
  530. return 0, syscall.EIO
  531. }
  532. ipVer := from[0] >> 4
  533. var head [4]byte
  534. switch ipVer {
  535. case 4:
  536. head[3] = syscall.AF_INET
  537. case 6:
  538. head[3] = syscall.AF_INET6
  539. default:
  540. return 0, fmt.Errorf("unable to determine IP version from packet")
  541. }
  542. // Grab rc as a local so the compiler can devirtualize the call and keep the closure on the stack.
  543. rc, err := t.f.SyscallConn()
  544. if err != nil {
  545. return 0, err
  546. }
  547. var n int
  548. var callErr error
  549. err = rc.Write(func(fd uintptr) bool {
  550. iovecs := []unix.Iovec{
  551. {Base: &head[0], Len: 4},
  552. {Base: &from[0], Len: uint64(len(from))},
  553. }
  554. n, callErr = tunWritev(int(fd), iovecs)
  555. // Type-assert to syscall.Errno so the EAGAIN/EWOULDBLOCK/EINTR check doesn't box the errno
  556. // constants into error interfaces on every call.
  557. if errno, ok := callErr.(syscall.Errno); ok && errno.Temporary() {
  558. return false
  559. }
  560. return true
  561. })
  562. if err != nil {
  563. return 0, err
  564. }
  565. if callErr != nil {
  566. return 0, callErr
  567. }
  568. return n - 4, nil
  569. }
  570. func (t *tun) Networks() []netip.Prefix {
  571. return t.vpnNetworks
  572. }
  573. func (t *tun) Name() string {
  574. return t.Device
  575. }
  576. func (t *tun) Queues(int) ([]tio.Queue, error) {
  577. return []tio.Queue{tio.NewSingleQueue(t, defaultBatchBufSize)}, nil
  578. }