1
0

relay_manager.go 18 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561
  1. package nebula
  2. import (
  3. "context"
  4. "encoding/binary"
  5. "errors"
  6. "fmt"
  7. "log/slog"
  8. "net/netip"
  9. "sync/atomic"
  10. "github.com/slackhq/nebula/cert"
  11. "github.com/slackhq/nebula/config"
  12. "github.com/slackhq/nebula/header"
  13. )
  14. type relayManager struct {
  15. l *slog.Logger
  16. hostmap *HostMap
  17. amRelay atomic.Bool
  18. useRelays atomic.Bool
  19. }
  20. func NewRelayManager(ctx context.Context, l *slog.Logger, hostmap *HostMap, c *config.C) *relayManager {
  21. rm := &relayManager{
  22. l: l,
  23. hostmap: hostmap,
  24. }
  25. rm.reload(c, true)
  26. c.RegisterReloadCallback(func(c *config.C) {
  27. err := rm.reload(c, false)
  28. if err != nil {
  29. rm.l.Error("Failed to reload relay_manager", "error", err)
  30. }
  31. })
  32. return rm
  33. }
  34. func (rm *relayManager) reload(c *config.C, initial bool) error {
  35. if initial || c.HasChanged("relay.am_relay") || c.HasChanged("relay.use_relays") {
  36. amRelay := c.GetBool("relay.am_relay", false)
  37. rm.amRelay.Store(amRelay)
  38. rm.useRelays.Store(c.GetBool("relay.use_relays", true) && !amRelay)
  39. }
  40. return nil
  41. }
  42. func (rm *relayManager) GetAmRelay() bool {
  43. return rm.amRelay.Load()
  44. }
  45. func (rm *relayManager) GetUseRelays() bool {
  46. return rm.useRelays.Load()
  47. }
  48. // StartRelays drives the relay-establishment side of an outbound handshake attempt.
  49. // For each candidate relay it either kicks off a handshake to the relay, sends a CreateRelayRequest, retransmits
  50. // one that may have been lost, or, once the relay is Established, forwards the in-progress
  51. // stage 0 handshake packet for vpnIp through it.
  52. func (rm *relayManager) StartRelays(f *Interface, vpnIp netip.Addr, hostinfo *HostInfo, stage0 []byte) {
  53. if !rm.GetUseRelays() || len(hostinfo.remotes.relays) == 0 {
  54. return
  55. }
  56. hostinfo.logger(rm.l).Info("Attempt to relay through hosts", "relays", hostinfo.remotes.relays)
  57. // Send a RelayRequest to all known Relay IP's
  58. for _, relay := range hostinfo.remotes.relays {
  59. // Don't relay through the host I'm trying to connect to
  60. if relay == vpnIp {
  61. continue
  62. }
  63. // Don't relay to myself
  64. if f.myVpnAddrsTable.Contains(relay) {
  65. continue
  66. }
  67. relayHostInfo := rm.hostmap.QueryVpnAddr(relay)
  68. if relayHostInfo == nil || !relayHostInfo.remote.IsValid() {
  69. hostinfo.logger(rm.l).Info("Establish tunnel to relay target", "relay", relay.String())
  70. f.Handshake(relay)
  71. continue
  72. }
  73. // Check the relay HostInfo to see if we already established a relay through
  74. existingRelay, ok := relayHostInfo.relayState.QueryRelayForByIp(vpnIp)
  75. if !ok {
  76. // No relays exist or requested yet.
  77. if relayHostInfo.remote.IsValid() {
  78. idx, err := AddRelay(rm.l, relayHostInfo, rm.hostmap, vpnIp, nil, TerminalType, Requested)
  79. if err != nil {
  80. hostinfo.logger(rm.l).Info("Failed to add relay to hostmap", "relay", relay.String(), "error", err)
  81. }
  82. m := NebulaControl{
  83. Type: NebulaControl_CreateRelayRequest,
  84. InitiatorRelayIndex: idx,
  85. }
  86. switch relayHostInfo.GetCert().Certificate.Version() {
  87. case cert.Version1:
  88. if !f.myVpnAddrs[0].Is4() {
  89. hostinfo.logger(rm.l).Error("can not establish v1 relay with a v6 network because the relay is not running a current nebula version")
  90. continue
  91. }
  92. if !vpnIp.Is4() {
  93. hostinfo.logger(rm.l).Error("can not establish v1 relay with a v6 remote network because the relay is not running a current nebula version")
  94. continue
  95. }
  96. b := f.myVpnAddrs[0].As4()
  97. m.OldRelayFromAddr = binary.BigEndian.Uint32(b[:])
  98. b = vpnIp.As4()
  99. m.OldRelayToAddr = binary.BigEndian.Uint32(b[:])
  100. case cert.Version2:
  101. m.RelayFromAddr = netAddrToProtoAddr(f.myVpnAddrs[0])
  102. m.RelayToAddr = netAddrToProtoAddr(vpnIp)
  103. default:
  104. hostinfo.logger(rm.l).Error("Unknown certificate version found while creating relay")
  105. continue
  106. }
  107. msg, err := m.Marshal()
  108. if err != nil {
  109. hostinfo.logger(rm.l).Error("Failed to marshal Control message to create relay", "error", err)
  110. } else {
  111. f.SendMessageToHostInfo(header.Control, 0, relayHostInfo, msg, make([]byte, 12), make([]byte, mtu))
  112. rm.l.Info("send CreateRelayRequest",
  113. "relayFrom", f.myVpnAddrs[0],
  114. "relayTo", vpnIp,
  115. "initiatorRelayIndex", idx,
  116. "relay", relay,
  117. )
  118. }
  119. }
  120. continue
  121. }
  122. switch existingRelay.State {
  123. case Established:
  124. hostinfo.logger(rm.l).Info("Send handshake via relay", "relay", relay.String())
  125. f.SendVia(relayHostInfo, existingRelay, stage0, make([]byte, 12), make([]byte, mtu), false)
  126. case Disestablished:
  127. // Mark this relay as 'requested'
  128. relayHostInfo.relayState.UpdateRelayForByIpState(vpnIp, Requested)
  129. fallthrough
  130. case Requested:
  131. hostinfo.logger(rm.l).Info("Re-send CreateRelay request", "relay", relay.String())
  132. // Re-send the CreateRelay request, in case the previous one was lost.
  133. m := NebulaControl{
  134. Type: NebulaControl_CreateRelayRequest,
  135. InitiatorRelayIndex: existingRelay.LocalIndex,
  136. }
  137. switch relayHostInfo.GetCert().Certificate.Version() {
  138. case cert.Version1:
  139. if !f.myVpnAddrs[0].Is4() {
  140. hostinfo.logger(rm.l).Error("can not establish v1 relay with a v6 network because the relay is not running a current nebula version")
  141. continue
  142. }
  143. if !vpnIp.Is4() {
  144. hostinfo.logger(rm.l).Error("can not establish v1 relay with a v6 remote network because the relay is not running a current nebula version")
  145. continue
  146. }
  147. b := f.myVpnAddrs[0].As4()
  148. m.OldRelayFromAddr = binary.BigEndian.Uint32(b[:])
  149. b = vpnIp.As4()
  150. m.OldRelayToAddr = binary.BigEndian.Uint32(b[:])
  151. case cert.Version2:
  152. m.RelayFromAddr = netAddrToProtoAddr(f.myVpnAddrs[0])
  153. m.RelayToAddr = netAddrToProtoAddr(vpnIp)
  154. default:
  155. hostinfo.logger(rm.l).Error("Unknown certificate version found while creating relay")
  156. continue
  157. }
  158. msg, err := m.Marshal()
  159. if err != nil {
  160. hostinfo.logger(rm.l).Error("Failed to marshal Control message to create relay", "error", err)
  161. } else {
  162. // This must send over the hostinfo, not over hm.Hosts[ip]
  163. f.SendMessageToHostInfo(header.Control, 0, relayHostInfo, msg, make([]byte, 12), make([]byte, mtu))
  164. rm.l.Info("send CreateRelayRequest",
  165. "relayFrom", f.myVpnAddrs[0],
  166. "relayTo", vpnIp,
  167. "initiatorRelayIndex", existingRelay.LocalIndex,
  168. "relay", relay,
  169. )
  170. }
  171. case PeerRequested:
  172. // PeerRequested only occurs in Forwarding relays, not Terminal relays, and this is a Terminal relay case.
  173. fallthrough
  174. default:
  175. hostinfo.logger(rm.l).Error("Relay unexpected state",
  176. "vpnIp", vpnIp,
  177. "state", existingRelay.State,
  178. "relay", relay,
  179. )
  180. }
  181. }
  182. }
  183. // AddRelay finds an available relay index on the hostmap, and associates the relay info with it.
  184. // relayHostInfo is the Nebula peer which can be used as a relay to access the target vpnIp.
  185. func AddRelay(l *slog.Logger, relayHostInfo *HostInfo, hm *HostMap, vpnIp netip.Addr, remoteIdx *uint32, relayType int, state int) (uint32, error) {
  186. hm.Lock()
  187. defer hm.Unlock()
  188. for range 32 {
  189. index, err := generateIndex(l)
  190. if err != nil {
  191. return 0, err
  192. }
  193. _, inRelays := hm.Relays[index]
  194. if !inRelays {
  195. // Avoid standing up a relay that can't be used since only the primary hostinfo
  196. // will be pointed to by the relay logic
  197. //TODO: if there was an existing primary and it had relay state, should we merge?
  198. hm.unlockedMakePrimary(relayHostInfo)
  199. hm.Relays[index] = relayHostInfo
  200. newRelay := Relay{
  201. Type: relayType,
  202. State: state,
  203. LocalIndex: index,
  204. PeerAddr: vpnIp,
  205. }
  206. if remoteIdx != nil {
  207. newRelay.RemoteIndex = *remoteIdx
  208. }
  209. relayHostInfo.relayState.InsertRelay(vpnIp, index, &newRelay)
  210. return index, nil
  211. }
  212. }
  213. return 0, errors.New("failed to generate unique localIndexId")
  214. }
  215. // EstablishRelay updates a Requested Relay to become an Established Relay, which can pass traffic.
  216. func (rm *relayManager) EstablishRelay(relayHostInfo *HostInfo, m *NebulaControl) (*Relay, error) {
  217. relay, ok := relayHostInfo.relayState.CompleteRelayByIdx(m.InitiatorRelayIndex, m.ResponderRelayIndex)
  218. if !ok {
  219. var relayFrom, relayTo any
  220. if m.RelayFromAddr == nil {
  221. relayFrom = m.OldRelayFromAddr
  222. } else {
  223. relayFrom = m.RelayFromAddr
  224. }
  225. if m.RelayToAddr == nil {
  226. relayTo = m.OldRelayToAddr
  227. } else {
  228. relayTo = m.RelayToAddr
  229. }
  230. rm.l.Info("relayManager failed to update relay",
  231. "relay", relayHostInfo.vpnAddrs[0],
  232. "initiatorRelayIndex", m.InitiatorRelayIndex,
  233. "relayFrom", relayFrom,
  234. "relayTo", relayTo,
  235. )
  236. return nil, fmt.Errorf("unknown relay")
  237. }
  238. return relay, nil
  239. }
  240. func (rm *relayManager) HandleControlMsg(h *HostInfo, d []byte, f *Interface) {
  241. msg := &NebulaControl{}
  242. err := msg.Unmarshal(d)
  243. if err != nil {
  244. h.logger(f.l).Error("Failed to unmarshal control message", "error", err)
  245. return
  246. }
  247. var v cert.Version
  248. if msg.OldRelayFromAddr > 0 || msg.OldRelayToAddr > 0 {
  249. v = cert.Version1
  250. b := [4]byte{}
  251. binary.BigEndian.PutUint32(b[:], msg.OldRelayFromAddr)
  252. msg.RelayFromAddr = netAddrToProtoAddr(netip.AddrFrom4(b))
  253. binary.BigEndian.PutUint32(b[:], msg.OldRelayToAddr)
  254. msg.RelayToAddr = netAddrToProtoAddr(netip.AddrFrom4(b))
  255. } else {
  256. v = cert.Version2
  257. }
  258. switch msg.Type {
  259. case NebulaControl_CreateRelayRequest:
  260. rm.handleCreateRelayRequest(v, h, f, msg)
  261. case NebulaControl_CreateRelayResponse:
  262. rm.handleCreateRelayResponse(v, h, f, msg)
  263. }
  264. }
  265. func (rm *relayManager) handleCreateRelayResponse(v cert.Version, h *HostInfo, f *Interface, m *NebulaControl) {
  266. rm.l.Info("handleCreateRelayResponse",
  267. "relayFrom", protoAddrToNetAddr(m.RelayFromAddr),
  268. "relayTo", protoAddrToNetAddr(m.RelayToAddr),
  269. "initiatorRelayIndex", m.InitiatorRelayIndex,
  270. "responderRelayIndex", m.ResponderRelayIndex,
  271. "vpnAddrs", h.vpnAddrs,
  272. )
  273. target := m.RelayToAddr
  274. targetAddr := protoAddrToNetAddr(target)
  275. relay, err := rm.EstablishRelay(h, m)
  276. if err != nil {
  277. rm.l.Error("Failed to update relay for relayTo", "error", err)
  278. return
  279. }
  280. // Do I need to complete the relays now?
  281. if relay.Type == TerminalType {
  282. return
  283. }
  284. // I'm the middle man. Let the initiator know that the I've established the relay they requested.
  285. peerHostInfo := rm.hostmap.QueryVpnAddr(relay.PeerAddr)
  286. if peerHostInfo == nil {
  287. rm.l.Error("Can't find a HostInfo for peer", "relayTo", relay.PeerAddr)
  288. return
  289. }
  290. peerRelay, ok := peerHostInfo.relayState.QueryRelayForByIp(targetAddr)
  291. if !ok {
  292. rm.l.Error("peerRelay does not have Relay state for relayTo", "relayTo", peerHostInfo.vpnAddrs[0])
  293. return
  294. }
  295. switch peerRelay.State {
  296. case Requested:
  297. // I initiated the request to this peer, but haven't heard back from the peer yet. I must wait for this peer
  298. // to respond to complete the connection.
  299. case PeerRequested, Disestablished, Established:
  300. peerHostInfo.relayState.UpdateRelayForByIpState(targetAddr, Established)
  301. resp := NebulaControl{
  302. Type: NebulaControl_CreateRelayResponse,
  303. ResponderRelayIndex: peerRelay.LocalIndex,
  304. InitiatorRelayIndex: peerRelay.RemoteIndex,
  305. }
  306. if v == cert.Version1 {
  307. peer := peerHostInfo.vpnAddrs[0]
  308. if !peer.Is4() {
  309. rm.l.Error("Refusing to CreateRelayResponse for a v1 relay with an ipv6 address",
  310. "relayFrom", peer,
  311. "relayTo", target,
  312. "initiatorRelayIndex", resp.InitiatorRelayIndex,
  313. "responderRelayIndex", resp.ResponderRelayIndex,
  314. "vpnAddrs", peerHostInfo.vpnAddrs,
  315. )
  316. return
  317. }
  318. b := peer.As4()
  319. resp.OldRelayFromAddr = binary.BigEndian.Uint32(b[:])
  320. b = targetAddr.As4()
  321. resp.OldRelayToAddr = binary.BigEndian.Uint32(b[:])
  322. } else {
  323. resp.RelayFromAddr = netAddrToProtoAddr(peerHostInfo.vpnAddrs[0])
  324. resp.RelayToAddr = target
  325. }
  326. msg, err := resp.Marshal()
  327. if err != nil {
  328. rm.l.Error("relayManager Failed to marshal Control CreateRelayResponse message to create relay", "error", err)
  329. } else {
  330. f.SendMessageToHostInfo(header.Control, 0, peerHostInfo, msg, make([]byte, 12), make([]byte, mtu))
  331. rm.l.Info("send CreateRelayResponse",
  332. "relayFrom", resp.RelayFromAddr,
  333. "relayTo", resp.RelayToAddr,
  334. "initiatorRelayIndex", resp.InitiatorRelayIndex,
  335. "responderRelayIndex", resp.ResponderRelayIndex,
  336. "vpnAddrs", peerHostInfo.vpnAddrs,
  337. )
  338. }
  339. }
  340. }
  341. func (rm *relayManager) handleCreateRelayRequest(v cert.Version, h *HostInfo, f *Interface, m *NebulaControl) {
  342. from := protoAddrToNetAddr(m.RelayFromAddr)
  343. target := protoAddrToNetAddr(m.RelayToAddr)
  344. logMsg := rm.l.With(
  345. "relayFrom", from,
  346. "relayTo", target,
  347. "initiatorRelayIndex", m.InitiatorRelayIndex,
  348. "vpnAddrs", h.vpnAddrs,
  349. )
  350. logMsg.Info("handleCreateRelayRequest")
  351. // Is the source of the relay me? This should never happen, but did happen due to
  352. // an issue migrating relays over to newly re-handshaked host info objects.
  353. if f.myVpnAddrsTable.Contains(from) {
  354. logMsg.Error("Discarding relay request from myself", "myIP", from)
  355. return
  356. }
  357. // Is the target of the relay me?
  358. if f.myVpnAddrsTable.Contains(target) {
  359. existingRelay, ok := h.relayState.QueryRelayForByIp(from)
  360. if ok {
  361. switch existingRelay.State {
  362. case Requested:
  363. ok = h.relayState.CompleteRelayByIP(from, m.InitiatorRelayIndex)
  364. if !ok {
  365. logMsg.Error("Relay State not found")
  366. return
  367. }
  368. case Established:
  369. if existingRelay.RemoteIndex != m.InitiatorRelayIndex {
  370. // We got a brand new Relay request, because its index is different than what we saw before.
  371. // This should never happen. The peer should never change an index, once created.
  372. logMsg.Error("Existing relay mismatch with CreateRelayRequest",
  373. "existingRemoteIndex", existingRelay.RemoteIndex)
  374. return
  375. }
  376. case Disestablished:
  377. if existingRelay.RemoteIndex != m.InitiatorRelayIndex {
  378. // We got a brand new Relay request, because its index is different than what we saw before.
  379. // This should never happen. The peer should never change an index, once created.
  380. logMsg.Error("Existing relay mismatch with CreateRelayRequest",
  381. "existingRemoteIndex", existingRelay.RemoteIndex)
  382. return
  383. }
  384. // Mark the relay as 'Established' because it's safe to use again
  385. h.relayState.UpdateRelayForByIpState(from, Established)
  386. case PeerRequested:
  387. // I should never be in this state, because I am terminal, not forwarding.
  388. logMsg.Error("Unexpected Relay State found",
  389. "existingRemoteIndex", existingRelay.RemoteIndex,
  390. "state", existingRelay.State)
  391. }
  392. } else {
  393. _, err := AddRelay(rm.l, h, f.hostMap, from, &m.InitiatorRelayIndex, TerminalType, Established)
  394. if err != nil {
  395. logMsg.Error("Failed to add relay", "error", err)
  396. return
  397. }
  398. }
  399. relay, ok := h.relayState.QueryRelayForByIp(from)
  400. if !ok {
  401. logMsg.Error("Relay State not found", "from", from)
  402. return
  403. }
  404. resp := NebulaControl{
  405. Type: NebulaControl_CreateRelayResponse,
  406. ResponderRelayIndex: relay.LocalIndex,
  407. InitiatorRelayIndex: relay.RemoteIndex,
  408. }
  409. if v == cert.Version1 {
  410. b := from.As4()
  411. resp.OldRelayFromAddr = binary.BigEndian.Uint32(b[:])
  412. b = target.As4()
  413. resp.OldRelayToAddr = binary.BigEndian.Uint32(b[:])
  414. } else {
  415. resp.RelayFromAddr = netAddrToProtoAddr(from)
  416. resp.RelayToAddr = netAddrToProtoAddr(target)
  417. }
  418. msg, err := resp.Marshal()
  419. if err != nil {
  420. logMsg.Error("relayManager Failed to marshal Control CreateRelayResponse message to create relay", "error", err)
  421. } else {
  422. f.SendMessageToHostInfo(header.Control, 0, h, msg, make([]byte, 12), make([]byte, mtu))
  423. rm.l.Info("send CreateRelayResponse",
  424. "relayFrom", from,
  425. "relayTo", target,
  426. "initiatorRelayIndex", resp.InitiatorRelayIndex,
  427. "responderRelayIndex", resp.ResponderRelayIndex,
  428. "vpnAddrs", h.vpnAddrs,
  429. )
  430. }
  431. return
  432. } else {
  433. // the target is not me. Create a relay to the target, from me.
  434. if !rm.GetAmRelay() {
  435. return
  436. }
  437. peer := rm.hostmap.QueryVpnAddr(target)
  438. if peer == nil {
  439. // Try to establish a connection to this host. If we get a future relay request,
  440. // we'll be ready!
  441. f.Handshake(target)
  442. return
  443. }
  444. if !peer.remote.IsValid() {
  445. // Only create relays to peers for whom I have a direct connection
  446. return
  447. }
  448. var index uint32
  449. var err error
  450. targetRelay, ok := peer.relayState.QueryRelayForByIp(from)
  451. if ok {
  452. index = targetRelay.LocalIndex
  453. } else {
  454. // Allocate an index in the hostMap for this relay peer
  455. index, err = AddRelay(rm.l, peer, f.hostMap, from, nil, ForwardingType, Requested)
  456. if err != nil {
  457. return
  458. }
  459. }
  460. peer.relayState.UpdateRelayForByIpState(from, Requested)
  461. // Send a CreateRelayRequest to the peer.
  462. req := NebulaControl{
  463. Type: NebulaControl_CreateRelayRequest,
  464. InitiatorRelayIndex: index,
  465. }
  466. if v == cert.Version1 {
  467. if !h.vpnAddrs[0].Is4() {
  468. rm.l.Error("Refusing to CreateRelayRequest for a v1 relay with an ipv6 address",
  469. "relayFrom", h.vpnAddrs[0],
  470. "relayTo", target,
  471. "initiatorRelayIndex", req.InitiatorRelayIndex,
  472. "responderRelayIndex", req.ResponderRelayIndex,
  473. "vpnAddr", target,
  474. )
  475. return
  476. }
  477. b := h.vpnAddrs[0].As4()
  478. req.OldRelayFromAddr = binary.BigEndian.Uint32(b[:])
  479. b = target.As4()
  480. req.OldRelayToAddr = binary.BigEndian.Uint32(b[:])
  481. } else {
  482. req.RelayFromAddr = netAddrToProtoAddr(h.vpnAddrs[0])
  483. req.RelayToAddr = netAddrToProtoAddr(target)
  484. }
  485. msg, err := req.Marshal()
  486. if err != nil {
  487. logMsg.Error("relayManager Failed to marshal Control message to create relay", "error", err)
  488. } else {
  489. f.SendMessageToHostInfo(header.Control, 0, peer, msg, make([]byte, 12), make([]byte, mtu))
  490. rm.l.Info("send CreateRelayRequest",
  491. "relayFrom", h.vpnAddrs[0],
  492. "relayTo", target,
  493. "initiatorRelayIndex", req.InitiatorRelayIndex,
  494. "responderRelayIndex", req.ResponderRelayIndex,
  495. "vpnAddr", target,
  496. )
  497. }
  498. // Also track the half-created Relay state just received
  499. _, ok = h.relayState.QueryRelayForByIp(target)
  500. if !ok {
  501. _, err := AddRelay(rm.l, h, f.hostMap, target, &m.InitiatorRelayIndex, ForwardingType, PeerRequested)
  502. if err != nil {
  503. logMsg.Error("relayManager Failed to allocate a local index for relay", "error", err)
  504. return
  505. }
  506. }
  507. }
  508. }